Skip to content
This repository was archived by the owner on Jul 1, 2021. It is now read-only.

bug(channel): Do not close closed channel #3

Merged
merged 5 commits into from
Feb 3, 2021

Conversation

rustatian
Copy link
Contributor

closes #2

@rustatian rustatian added the bug Something isn't working label Feb 1, 2021
@rustatian rustatian self-assigned this Feb 1, 2021
@rustatian rustatian requested a review from wolfy-j February 1, 2021 14:42
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #3 (52981c3) into master (41d3e70) will increase coverage by 9.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   81.86%   91.66%   +9.80%     
==========================================
  Files           6        4       -2     
  Lines         193       96      -97     
==========================================
- Hits          158       88      -70     
+ Misses         22        5      -17     
+ Partials       13        3      -10     
Impacted Files Coverage Δ
conn_context.go 100.00% <ø> (+12.50%) ⬆️
conn_pool.go 93.61% <ø> (-0.27%) ⬇️
service.go 100.00% <ø> (+26.31%) ⬆️
access_validator.go 80.76% <100.00%> (ø)
rpc.go
config.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d3e70...52981c3. Read the comment docs.

@rustatian rustatian merged commit 3507609 into master Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about panic 'send on closed channel'
2 participants