CROSSSLOT keys issue fix when using redis cluster #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveen-chidhambaram
force-pushed
the
main
branch
from
1cdd319 to
4ae6399
Compare
andrehjr
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
It would be awesome to add an spec for this. If you want to add one later, that would be cool :) I might add one later. Sorry for taking too long!
The push/renames look good to me.
with redis-namespace:
1690243266.694866 [0 [::1]:57123] "MULTI"
1690243266.694891 [0 [::1]:57123] "rpush" "ns:some_list_tmp{ns:some_list}" "1" "2" "3"
1690243266.694915 [0 [::1]:57123] "rename" "ns:some_list_tmp{ns:some_list}" "ns:some_list"
1690243266.694925 [0 [::1]:57123] "EXEC"
without redis-namespace
1690243327.047441 [0 [::1]:57144] "MULTI"
1690243327.047461 [0 [::1]:57144] "rpush" "some_list_tmp{some_list}" "1" "2" "3"
1690243327.047469 [0 [::1]:57144] "rename" "some_list_tmp{some_list}" "some_list"
1690243327.047479 [0 [::1]:57144] "EXEC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #709
spec/spec_helper.rbbased on the compatible redis gem version.