Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported features for Android API levels lower than 19, which cause crashes #78

Closed
d-u-a-l opened this issue Oct 5, 2019 · 3 comments
Closed

Unsupported features for Android API levels lower than 19, which cause crashes #78

d-u-a-l opened this issue Oct 5, 2019 · 3 comments
Assignees
@srikanth-lingala
Labels
bug Something isn't working

Comments

@d-u-a-l
Copy link

d-u-a-l commented Oct 5, 2019

Latest release uses
java.nio.charset.StandardCharsets
which available in Android starting with API level 19 (Kitkat). When I use library, no warnings about it not supporting older versions of Android (Jelly Bean, for example) were issued by Android Studio. You should change minSdk to 19 or make a workaround for API levels lower than 19
@nicolabeghin
Copy link

nicolabeghin commented Oct 5, 2019 •
edited
Loading

Following, any plan for a hotfix? Thanks a lot!

AFAIK in order to maintain compatibility with lots of Android levels (<19) it makes sense to avoid using StandardCharset class, which only contains 6 constants for Charset.forName

https://github.com/openjdk-mirror/jdk7u-jdk/blob/master/src/share/classes/java/nio/charset/StandardCharsets.java

@srikanth-lingala srikanth-lingala self-assigned this Oct 5, 2019
@srikanth-lingala srikanth-lingala added the bug Something isn't working label Oct 5, 2019
srikanth-lingala added a commit that referenced this issue Oct 6, 2019
@srikanth-lingala
#78 Replace StandardCharset with Charset.forName
06b16f7
@nicolabeghin nicolabeghin mentioned this issue Oct 6, 2019
Closed
@nicolabeghin
Copy link

@srikanth-lingala pushed PR #79, please take a look if it makes sense for you, thanks!

@srikanth-lingala
Copy link
Owner

Fixed in v2.2.2 released today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanth-lingala srikanth-lingala

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolabeghin @srikanth-lingala @d-u-a-l