Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

substitution of setRootFolderInZip? #97

Closed
tRavAsty opened this issue Oct 29, 2019 · 3 comments
Closed

substitution of setRootFolderInZip? #97

tRavAsty opened this issue Oct 29, 2019 · 3 comments
Assignees
@srikanth-lingala
Labels
bug Something isn't working

Comments

@tRavAsty
Copy link

Hi there,
we are upgrading our zip4j dependency from 1.3.2 to 2.1.0, although we were able to substitue several constructors and functions (such as Zip4jConstants.COMP_STORE to CompressionMethod.STORE, etc), we cannot find the substitution of ZipParameters::setRootFolderInZip function, can you give us any idea about how should we upgrade it to zip4j version 2?
@srikanth-lingala
Copy link
Owner

Looks like this feature was missed during the migration. I will add it back.

@srikanth-lingala srikanth-lingala self-assigned this Oct 31, 2019
@srikanth-lingala srikanth-lingala added the bug Something isn't working label Oct 31, 2019
srikanth-lingala added a commit that referenced this issue Nov 4, 2019
@srikanth-lingala
#97 Reintroduce setRootFolderInZip in ZipParameters
04f0264
@srikanth-lingala
Copy link
Owner

I have added a feature ZipParameters.setRootFolderNameInZip(). Will include it in the next release.

@srikanth-lingala
Copy link
Owner

Featured added in v2.2.4 released today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanth-lingala srikanth-lingala

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srikanth-lingala @tRavAsty