Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional jinja2 dependency #1144

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Jun 5, 2023

Related Issue(s):

Description:

#1142 still relies on jinja2 being installed, so it is totally independent of this PR

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@jsignell
Copy link
Member Author

jsignell commented Jun 5, 2023

not sure if this needs a changelog or not @gadomski

@jsignell jsignell requested a review from gadomski June 5, 2023 20:39
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5402e71) 90.94% compared to head (7fac3a5) 90.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1144   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          49       49           
  Lines        6645     6645           
  Branches      982      982           
=======================================
  Hits         6043     6043           
  Misses        422      422           
  Partials      180      180           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsignell jsignell self-assigned this Jun 5, 2023
@gadomski gadomski added this to the 1.8 milestone Jun 5, 2023
@jsignell jsignell added this pull request to the merge queue Jun 6, 2023
Merged via the queue into stac-utils:main with commit e6d5d75 Jun 6, 2023
@jsignell jsignell deleted the jinja2-dep branch June 6, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add jinja2 as an extra for accessing formatted html representation of Collections and Items
2 participants