Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstring of name argument to Classification.apply to agree with extension specification #1356

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

bmcandr
Copy link
Contributor

@bmcandr bmcandr commented Jun 25, 2024

Related Issue(s):

Description: Update docstring of name argument to Classification.apply and Classification.create to agree with extension specification.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (dc4d9af) to head (26a5c53).
Report is 40 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1356   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files          51       51           
  Lines        7042     7042           
  Branches     1008     1008           
=======================================
  Hits         6424     6424           
  Misses        443      443           
  Partials      175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski added this pull request to the merge queue Jul 1, 2024
Merged via the queue into stac-utils:main with commit ff67de3 Jul 1, 2024
24 checks passed
@bmcandr bmcandr deleted the fix/classification-name-docstring branch July 1, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants