Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adde enum MediaType for PDF files #758

Merged
merged 3 commits into from
Mar 4, 2022

Conversation

KennSmithDS
Copy link
Contributor

@KennSmithDS KennSmithDS commented Mar 1, 2022

Related Issue(s): #
N/A

Description:
Radiant MLHub team consistently uses PDF files as documentation reference to accompany published datasets. Instead of requiring us to serialize an Item to dictionary to add the custom MediaType and deserialize back to STAC Item Object, adding this Enum type simplifies a process we frequently execute. It's also a common media file type.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb requested a review from gadomski March 3, 2022 20:56
@duckontheweb duckontheweb merged commit ea678f0 into stac-utils:main Mar 4, 2022
@guidorice
Copy link
Contributor

@duckontheweb @gadomski @KennSmithDS just an idea: maybe this media type should be broken up into two types?

  • documentation PDF
  • georeferenced PDF

I did a quick search but cannot tell if georeferenced pdfs have the same or different MIME type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants