Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return None from Asset.get_absolute_href when owning Item self HREF is NOne #808

Merged

Conversation

duckontheweb
Copy link
Contributor

**Related Issue(s):

Description:

Asset.get_absolute_href now returns None when the owning Item has no self HREF.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb added this to the 1.5.0 milestone May 13, 2022
@duckontheweb duckontheweb requested a review from gadomski May 13, 2022 21:37
@duckontheweb
Copy link
Contributor Author

cc: @Kirill888

@codecov-commenter
Copy link

Codecov Report

Merging #808 (ad194a2) into main (3526b65) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
+ Coverage   94.31%   94.32%   +0.01%     
==========================================
  Files          83       83              
  Lines       11873    11885      +12     
  Branches     1387     1388       +1     
==========================================
+ Hits        11198    11211      +13     
+ Misses        496      495       -1     
  Partials      179      179              
Impacted Files Coverage Δ
pystac/asset.py 86.11% <100.00%> (+1.82%) ⬆️
tests/test_item.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3526b65...ad194a2. Read the comment docs.

@duckontheweb duckontheweb merged commit 1261e60 into stac-utils:main May 17, 2022
@duckontheweb duckontheweb deleted the fix/754-asset-absolute-href branch June 7, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset.get_absolute_href() should return None but doesn't
3 participants