Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies #897

Merged
merged 5 commits into from
Oct 10, 2022
Merged

Fix dependencies #897

merged 5 commits into from
Oct 10, 2022

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Oct 10, 2022

Related Issue(s):

Should unblock #895, #882, and others.

Description:

Dependency resolution was broken for pip install -r requirements-dev.txt:

$ pip install -r requirements-dev.txt
... snip ...
ERROR: Cannot install -r ./requirements-docs.txt (line 2), -r ./requirements-docs.txt (line 4), -r ./requirements-docs.txt (line 5), -r ./requirements-docs.txt (line 6) and -r ./requirements-test.txt (line 9) because these package versions have conflicting dependencies.

The conflict is caused by:
    sphinx 4.5.0 depends on docutils<0.18 and >=0.14
    nbsphinx 0.8.9 depends on docutils
    pydata-sphinx-theme 0.8.1 depends on docutils!=0.17.0
    sphinx-panels 0.6.0 depends on docutils
    doc8 1.0.0 depends on docutils<0.21 and >=0.19

This wasn't caught by CI because we never install requirements-dev.txt on CI. This PR:

  1. Adds a check for requirements-dev.txt install
  2. Downgrades doc8 version to fix the break
  3. Updates the python-version for 3.11 to rc.2
  4. Does some minor linting on the CI file.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

This was causing a dependency resolution conflict, uncaught by CI.
@gadomski gadomski merged commit 859f4bb into main Oct 10, 2022
@gadomski gadomski deleted the fix-dependencies branch October 10, 2022 15:28
@gadomski gadomski mentioned this pull request Oct 10, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants