Add start and end datetimes to Item.__init__
#918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 94.31% // Head: 94.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
=======================================
Coverage 94.31% 94.32%
=======================================
Files 80 80
Lines 11923 11937 +14
Branches 1130 1132 +2
=======================================
+ Hits 11245 11259 +14
Misses 496 496
Partials 182 182
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gadomski
force-pushed
the
issues/905-start-end-datetime
branch
from
7a5deda to
ddfd53b
Compare
gadomski
force-pushed
the
issues/905-start-end-datetime
branch
from
e415c10 to
802944a
Compare
gadomski
force-pushed
the
issues/905-start-end-datetime
branch
from
802944a to
c304b27
Compare
gadomski
force-pushed
the
issues/905-start-end-datetime
branch
from
c304b27 to
a86fab0
Compare
These values allow you to pass a datetime, instead of having to convert it to a string and put it into properties.
gadomski
force-pushed
the
issues/905-start-end-datetime
branch
from
a86fab0 to
b2821ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
It's pretty awkward to provide
start_datetimeandend_datetimeas strings inproperties, when you can provide a datetime object asdatetime. This PR adds two optional arguments to setstart_datetimeandend_datetimein the constructor. These values will override anything set inproperties.PR Checklist:
pre-commit run --all-files)scripts/test)