-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump projection extension to v1.1.0 #989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the projection v1.1.0 schema in the test data files?
@gadomski - Let me know if you think we should add more tests to explicitly cover v1.0 vs v1.1 changes. The one added example covers the optional |
Codecov ReportBase: 90.05% // Head: 90.06% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #989 +/- ##
==========================================
+ Coverage 90.05% 90.06% +0.01%
==========================================
Files 47 47
Lines 6162 6162
Branches 917 917
==========================================
+ Hits 5549 5550 +1
Misses 431 431
+ Partials 182 181 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I only guessed that local files might be used instead of making network requests when validating. But I didn't confirm. I'll remove it and see how it works. |
@gadomski - Looks like tests pass without the schema file. Latest commit omits it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @tschaub I just went ahead and made the doc+examples update since I was in the code -- I added a note to docs/contributing.rst
about those changes. Do you mind taking a look at those, and then we should be good to ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @gadomski. Thanks for updating the docs and notebook. It looks like there are some pretty significant (unrelated) changes in the notebook. Assuming that might just be because it hasn't been updated / run in a while.
Yup, the biggest change is adding the HTML output (enabled by #743), but I figured it wasn't worth doing a new PR just w/ that update. Thanks for checking. |
Related Issue(s): #
stac-extensions/projection#17
Description:
This updates the projection extension to use v1.1.0.
PR Checklist:
pre-commit run --all-files
)scripts/test
)