Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump projection extension to v1.1.0 #989

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Conversation

tschaub
Copy link
Contributor

@tschaub tschaub commented Feb 15, 2023

Related Issue(s): #

stac-extensions/projection#17

Description:

This updates the projection extension to use v1.1.0.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski self-requested a review February 15, 2023 18:04
@gadomski gadomski added the extension Implement a STAC extension in PySTAC label Feb 15, 2023
@gadomski gadomski added this to the 1.7 milestone Feb 15, 2023
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the projection v1.1.0 schema in the test data files?

@tschaub
Copy link
Contributor Author

tschaub commented Feb 15, 2023

@gadomski - Let me know if you think we should add more tests to explicitly cover v1.0 vs v1.1 changes. The one added example covers the optional proj:epsg property at the item level. I also didn't update notebooks or other examples that use the projection schema URL. Happy to make additional changes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Base: 90.05% // Head: 90.06% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (285e2aa) compared to base (be0b6c0).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   90.05%   90.06%   +0.01%     
==========================================
  Files          47       47              
  Lines        6162     6162              
  Branches      917      917              
==========================================
+ Hits         5549     5550       +1     
  Misses        431      431              
+ Partials      182      181       -1     
Impacted Files Coverage Δ
pystac/extensions/projection.py 98.47% <100.00%> (ø)
pystac/extensions/hooks.py 83.05% <0.00%> (+1.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tschaub
Copy link
Contributor Author

tschaub commented Feb 15, 2023

Do we need the projection v1.1.0 schema in the test data files?

I only guessed that local files might be used instead of making network requests when validating. But I didn't confirm. I'll remove it and see how it works.

@tschaub
Copy link
Contributor Author

tschaub commented Feb 15, 2023

I only guessed that local files might be used instead of making network requests when validating. But I didn't confirm. I'll remove it and see how it works.

@gadomski - Looks like tests pass without the schema file. Latest commit omits it.

@gadomski gadomski self-requested a review February 15, 2023 18:15
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @tschaub I just went ahead and made the doc+examples update since I was in the code -- I added a note to docs/contributing.rst about those changes. Do you mind taking a look at those, and then we should be good to ?

Copy link
Contributor Author

@tschaub tschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @gadomski. Thanks for updating the docs and notebook. It looks like there are some pretty significant (unrelated) changes in the notebook. Assuming that might just be because it hasn't been updated / run in a while.

@gadomski
Copy link
Member

It looks like there are some pretty significant (unrelated) changes in the notebook. Assuming that might just be because it hasn't been updated / run in a while.

Yup, the biggest change is adding the HTML output (enabled by #743), but I figured it wasn't worth doing a new PR just w/ that update. Thanks for checking.

@gadomski gadomski added this pull request to the merge queue Feb 15, 2023
Merged via the queue into stac-utils:main with commit 7819728 Feb 15, 2023
@tschaub tschaub deleted the proj-bump branch February 15, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension Implement a STAC extension in PySTAC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants