Use flake-parts #40
Merged
Use flake-parts #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedorich-n
commented
Feb 13, 2024
sestrella
reviewed
Feb 16, 2024
sestrella
previously approved these changes
Feb 16, 2024
There was a problem hiding this comment.
@pedorich-n overall, your draft PR looks great; we appreciate you taking the time to work on it, and we look forward to seeing the final version of this PR.
sestrella
dismissed
their stale review
I meant to write a comment, not to approve this PR because it is still a draft. My bad!
pedorich-n
commented
Feb 17, 2024
sestrella
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
@pedorich-n this PR looks great as is, and I would be happy to merge it; still I would like to hear your thoughts on my previous comment regarding how to handle unfree packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I wanted to suggest you guys switch from
flake-utilstoflake-parts, but I realized it might be better to make the first draft to showcase its strengths.Quick intro: flake-parts is a framework for writing flakes with an emphasis on modularity and customizability. It provides a lot of handy tools to simplify your code.
I've split the
flake.nixintolib.nixandpackages.nix. Wherelibexposes thebuildTerraformfunction andpackagesbuilds all the packages.Flake output should stay the same:
packages,devShells.default,lib, except I also addedoverlays, so this PR closes #17.In my opinion, the separation makes the repository easier to follow and allows future changes to be done easily.
If you think it's worth merging, I'll update the documentation.
Let me know your thoughts!
Also: feel free to reject it, as this is completely my own initiative, and no one asked for this. 😄