Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Build packages by cycle / Push builds to Cachix #54

Merged
merged 9 commits into from
Mar 4, 2024

Conversation

sestrella
Copy link
Member

@sestrella sestrella commented Mar 1, 2024

Closes #53

Copy link
Contributor

@oscar-izval oscar-izval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like it needs a full rebuild, so it may take a few more retries.

@sestrella
Copy link
Member Author

@oscar-izval I'm planning to remove the timeout temporarily, but it appears that we require a more robust solution for these scenarios. As we plan to add support for more systems, I believe it is necessary to revisit this workflow; however, I will merge this one once it turns green and open an issue to begin discussing how we can handle full rebuilds better.

@sestrella sestrella closed this Mar 1, 2024
@sestrella sestrella reopened this Mar 1, 2024
@sestrella sestrella changed the title fix: Add missing checks to flake.nix fix: Build packages by cycle / Push builds to Cachix Mar 4, 2024
# INFO: This is only a workaround to avoid timeout issues with the CI;
# whether it becomes a definitive solution or not will require a
# separate discussion with Oscar.
cycle:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oscar-izval Please let me know if this appears to be a reasonable solution for the time being, as I believe it is important to address the issue reported in #53

@sestrella sestrella merged commit efba3eb into main Mar 4, 2024
10 of 11 checks passed
@sestrella sestrella deleted the add_checks_to_flake branch March 4, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are recent builds updating the binary cache?
2 participants