Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTools45 compatibility #1066

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RTools45 compatibility #1066

wants to merge 1 commit into from

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

R4.5 and RTools4.5 will be releasing soon, so we need to add handling for the new version. I think we'll probably also need to do another release (just a v0.9, not the full v1.0) so that users can pickup the binaries from R-Universe

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@andrjohns
Copy link
Collaborator Author

MacOS r-devel failures are unrelated, there are currently issues with their changes to handling libintl: https://stat.ethz.ch/pipermail/r-sig-mac/2025-March/015125.html

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good.

I think we'll probably also need to do another release (just a v0.9, not the full v1.0) so that users can pickup the binaries from R-Universe

Ok, I guess in that case it's good I haven't merged #1061 yet. We can wait to merge that until after v0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants