-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@xstate/store] Add store.inspect(…)
#5027
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
--- | ||
'@xstate/store': minor | ||
--- | ||
|
||
You can now inspect XState stores using the `.inspect(inspector)` method: | ||
|
||
```ts | ||
import { someStore } from './someStore'; | ||
|
||
someStore.inspect((inspEv) => { | ||
console.log(inspEv); | ||
// logs "@xstate.event" events and "@xstate.snapshot" events | ||
// whenever an event is sent to the store | ||
}); | ||
// The "@xstate.actor" event is immediately logged | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import type { InspectionEvent } from 'xstate'; | ||
import { | ||
Recipe, | ||
EventPayloadMap, | ||
|
@@ -41,6 +42,11 @@ function setter<TContext extends StoreContext>( | |
return recipe(context); | ||
} | ||
|
||
const inspectionObservers = new WeakMap< | ||
Store<any, any>, | ||
Set<Observer<InspectionEvent>> | ||
>(); | ||
|
||
function createStoreCore< | ||
TContext extends StoreContext, | ||
TEventPayloadMap extends EventPayloadMap | ||
|
@@ -76,11 +82,31 @@ function createStoreCore< | |
function receive(event: StoreEvent) { | ||
currentSnapshot = transition(currentSnapshot, event); | ||
|
||
inspectionObservers.get(store)?.forEach((observer) => { | ||
observer.next?.({ | ||
type: '@xstate.snapshot', | ||
event, | ||
snapshot: currentSnapshot, | ||
actorRef: store, | ||
rootId: store.sessionId | ||
}); | ||
}); | ||
|
||
observers?.forEach((o) => o.next?.(currentSnapshot)); | ||
} | ||
|
||
const store: Store<TContext, StoreEvent> = { | ||
sessionId: 'test', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. :cough: :cough: |
||
send(event) { | ||
inspectionObservers.get(store)?.forEach((observer) => { | ||
observer.next?.({ | ||
type: '@xstate.event', | ||
event, | ||
sourceRef: undefined, | ||
actorRef: store, | ||
rootId: store.sessionId | ||
}); | ||
}); | ||
receive(event as unknown as StoreEvent); | ||
}, | ||
getSnapshot() { | ||
|
@@ -102,6 +128,34 @@ function createStoreCore< | |
}, | ||
[symbolObservable](): InteropSubscribable<StoreSnapshot<TContext>> { | ||
return this; | ||
}, | ||
inspect: (observerOrFn) => { | ||
const observer = toObserver(observerOrFn); | ||
inspectionObservers.set( | ||
store, | ||
inspectionObservers.get(store) ?? new Set() | ||
); | ||
inspectionObservers.get(store)!.add(observer); | ||
|
||
observer.next?.({ | ||
type: '@xstate.actor', | ||
actorRef: store, | ||
rootId: store.sessionId | ||
}); | ||
|
||
observer.next?.({ | ||
type: '@xstate.snapshot', | ||
snapshot: initialSnapshot, | ||
event: { type: '@xstate.init' }, | ||
actorRef: store, | ||
rootId: store.sessionId | ||
}); | ||
|
||
return { | ||
unsubscribe() { | ||
return inspectionObservers.get(store)?.delete(observer); | ||
} | ||
}; | ||
} | ||
}; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
import { InspectionEvent } from 'xstate'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
export type EventPayloadMap = Record<string, {} | null | undefined>; | ||
|
||
export type ExtractEventsFromPayloadMap<T extends EventPayloadMap> = Values<{ | ||
|
@@ -64,6 +66,19 @@ export interface Store<TContext, Ev extends EventObject> | |
send: (event: Ev) => void; | ||
getSnapshot: () => StoreSnapshot<TContext>; | ||
getInitialSnapshot: () => StoreSnapshot<TContext>; | ||
/** | ||
* Subscribes to [inspection events](https://stately.ai/docs/inspection) from | ||
* the store. | ||
* | ||
* Inspectors that call `store.inspect(…)` will immediately receive an | ||
* "@xstate.actor" inspection event. | ||
*/ | ||
inspect: ( | ||
observer: | ||
| Observer<InspectionEvent> | ||
| ((inspectionEvent: InspectionEvent) => void) | ||
) => Subscription; | ||
sessionId: string; | ||
} | ||
|
||
export type SnapshotFromStore<TStore extends Store<any, any>> = | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xstate/store
doesn't depend onxstate
, you can't reach for its types here