Add initial support for xstate/store/solid #5056
Conversation
🦋 Changeset detectedLatest commit: 4136506 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
steveadams
force-pushed
the
xstate-store/solid
branch
from
de5769f to
ad3f388
Compare
steveadams
force-pushed
the
xstate-store/solid
branch
from
ad3f388 to
f4b00c2
Compare
|
Apologies for the force pushes; I can move this to a clean branch with a single commit instead if they're a problem. |
| * previously selected value | ||
| * @returns A read-only signal of the selected value | ||
| */ | ||
| export function useSelector<TStore extends Store<any, any>, T>( |
There was a problem hiding this comment.
I initially went with the name createSelector, and I might actually prefer it. I'm not sure what the consensus is on naming functions like this in SolidJS. The library itself has use* as well as create* naming conventions for functions like this.
There was a problem hiding this comment.
That's fine, whatever is most idiomatic!
There was a problem hiding this comment.
I'm just noticing the other solid-related code uses useActor and useMachine for example so I think this makes sense.
|
You're welcome! I really enjoyed this process and I'm stoked to contribute to XState. |
I've added
useSelectorsupport to xstate/store for SolidJS which seems to be working well in my tests. Let me know what I can improve and I'd be happy to do it.