Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C API to @stdlib/math/base/special/lucas #931

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

Jordan-Gallivan
Copy link
Contributor

@Jordan-Gallivan Jordan-Gallivan commented Feb 28, 2023

Resolves #892 .

Description implementation of the C stdlib_base_lucas

What is the purpose of this pull request?

This pull request:

  • implements all C files associated with the lucas function

Related Issues

Does this pull request have any related issues? No

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

@kgryte Wanted to give you a heads up that, when viewed in dark mode, the initial definition of the READMEs are hard to see (they're in black font).

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Feb 28, 2023
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Jordan-Gallivan!

@kgryte
Copy link
Member

kgryte commented Feb 28, 2023

@Jordan-Gallivan Re: dark mode. Is this when viewing the Markdown on GitHub or elsewhere?

@kgryte
Copy link
Member

kgryte commented Feb 28, 2023

You mind posting a screenshot?

@kgryte kgryte changed the title C implementation for stdlib_base_lucas() feat: add C API to @stdlib/math/base/special/lucas Feb 28, 2023
@kgryte kgryte merged commit e3fcd52 into stdlib-js:develop Feb 28, 2023
@Jordan-Gallivan
Copy link
Contributor Author

@kgryte
See attached:
Screenshot 2023-02-28 at 10 47 36 AM

@kgryte
Copy link
Member

kgryte commented Feb 28, 2023

Ah, thanks for sharing. Hmm...I am not sure what we can do about this, as the equations are in SVG. Maybe we can hook into GitHub's theming. Will add to our internal todo tracker. Thanks for flagging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/lucas
2 participants