Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

844 username routes 404 #851

Merged
merged 5 commits into from
Dec 20, 2016
Merged

844 username routes 404 #851

merged 5 commits into from
Dec 20, 2016

Conversation

originated
Copy link
Contributor

No description provided.

@roadscape
Copy link
Contributor

Someone recently refactored route logic so the useprofile regex only lives in app/ResolveRoute.js:4:

UserProfile2: /^\/(@[\w\.\d-]+)\/(blog|posts|comments|recommended|transfers|curation-rewards|author-rewards|permissions|created|recent-replies|feed|password|followed|followers|settings)\/?$/,

Can we leverage this instead of using userEndpoints?

@originated
Copy link
Contributor Author

@roadscape Did a bit of refactoring, going forward all the route paths/matches can live here. 1. moved settings into the resolve route(also refactored some other patterns we had for good practice). 2. For the particular matching it's helpful to have the additional variation, but it now lives in the global route area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants