Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make serde dependency optional #102

Merged
merged 6 commits into from
Jul 14, 2022
Merged

Make serde dependency optional #102

merged 6 commits into from
Jul 14, 2022

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Jul 14, 2022

What

Make serde dependency optional. Also run tests and builds against the serde feature.

Why

The serde dependency shouldn't be included in the dependency tree unless the serde feature is enabled.

@leighmcculloch leighmcculloch enabled auto-merge (squash) July 14, 2022 18:02
@leighmcculloch leighmcculloch requested a review from sisuresh July 14, 2022 18:02
@leighmcculloch leighmcculloch disabled auto-merge July 14, 2022 18:03
@leighmcculloch leighmcculloch enabled auto-merge (squash) July 14, 2022 18:08
@leighmcculloch
Copy link
Member Author

leighmcculloch commented Jul 14, 2022

This change includes a TODO to remove the --optional-deps usage once weak dependencies are recognized by cargo-hack (taiki-e/cargo-hack#147) and once the bug with first-class features that have the same name as an optional dependency not being seen as a feature to test is addressed (taiki-e/cargo-hack#153).

@leighmcculloch leighmcculloch merged commit 1bebcde into main Jul 14, 2022
@leighmcculloch leighmcculloch deleted the optionalserde branch July 14, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant