Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test that covers transaction set building logic on randomized data. #4507

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Oct 16, 2024

Description

Add a test that covers transaction set building logic on randomized data.

While this is not comprehensive (and probably can't be), I think that will add increase our confidence in the upcoming tx set refactoring and might prevent accidental changes in the future.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@dmkozh dmkozh force-pushed the txset_test branch 5 times, most recently from d89f940 to badb9e5 Compare October 23, 2024 18:12
@dmkozh dmkozh force-pushed the txset_test branch 4 times, most recently from 3b258fb to 931f946 Compare October 25, 2024 20:35
…ata.

While this is not comprehensive (and probably can't be), I think that will add increase our confidence in the upcoming tx set refactoring and might prevent accidental changes in the future.
@dmkozh dmkozh marked this pull request as ready for review October 25, 2024 22:22
@dmkozh dmkozh added this pull request to the merge queue Nov 4, 2024
Merged via the queue into stellar:master with commit ef84d82 Nov 5, 2024
13 checks passed
@dmkozh dmkozh deleted the txset_test branch November 5, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants