Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickwin/KAD-4019 #664

Merged
merged 9 commits into from
Feb 24, 2025
Merged

quickwin/KAD-4019 #664

merged 9 commits into from
Feb 24, 2025

Conversation

gilbert-hernandez
Copy link
Contributor

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-4019
...

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

Copy link
Contributor

@oakesjosh oakesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradient text and Google fonts are not displaying for me in the editor

@gilbert-hernandez
Copy link
Contributor Author

Fixed Google fonts in editor. Still trying to figure out why the gradient text disappears. The same is true for the advanced text block highlight. On page load, you can see the gradient text in the editor. However, after the user selects the block, the gradient text goes away and does not come back even after selecting a different block.

@gilbert-hernandez
Copy link
Contributor Author

Fixed the highlight colors in the editor for the icon list and advanced text block. I also fixed the reset value for the highlight color in the backend and frontend.

Copy link

github-actions bot commented Feb 17, 2025

🎉 Zip build complete

Build timestamp

@gilbert-hernandez gilbert-hernandez merged commit e58c665 into master Feb 24, 2025
25 checks passed
@gilbert-hernandez gilbert-hernandez deleted the quickwin/KAD-4019 branch February 24, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants