Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/KAD-4150 #668

Merged
merged 2 commits into from
Feb 17, 2025
Merged

bugfix/KAD-4150 #668

merged 2 commits into from
Feb 17, 2025

Conversation

gilbert-hernandez
Copy link
Contributor

🎫 #[Jira Ticket]
https://stellarwp.atlassian.net/browse/KAD-4150
...

Checklist

  • I have performed a self-review.
  • No unrelated files are modified.
  • No debugging statements exist (Ex: console.log, error_log).
  • There are no warnings or notices in the wordpress error log.
  • Passes all tests (linting, acceptance, & unit)

Block specific checklist (where relevant)

  • Tested with an existing instance of this block .
  • Tested creating a new instance of this block.
  • Tested with Dynamic content & Elements.

@mark-c-woodard
Copy link
Contributor

mark-c-woodard commented Feb 13, 2025 •
edited
Loading

this looks good, I think it would be cleaner as a ternary though.

@github-actions GitHub Actions
Copy link

🎉 Build artifacts

@gilbert-hernandez gilbert-hernandez merged commit 30a056f into master Feb 17, 2025
25 checks passed
@gilbert-hernandez gilbert-hernandez deleted the bugfix/KAD-4150 branch February 17, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oakesjosh oakesjosh oakesjosh approved these changes

@mark-c-woodard mark-c-woodard Awaiting requested review from mark-c-woodard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilbert-hernandez @mark-c-woodard @oakesjosh