Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'pacdef package review' enhancement suggestions #36

Open
ostrich opened this issue May 29, 2023 · 7 comments · May be fixed by #42
Open

'pacdef package review' enhancement suggestions #36

ostrich opened this issue May 29, 2023 · 7 comments · May be fixed by #42
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ostrich
Copy link

ostrich commented May 29, 2023

A couple minor changes to pacdef package review would improve it a lot.

  1. Offer to save the group assignments on q quit. Currently all changes are lost until the entire list has been reviewed.
  2. Allow multiple space delimited group assignments at the group assignment prompt.

Some other changes would improve it even more.

  1. Allow going back to the previous package.
  2. Allow creation of new groups while reviewing (understand if this is out of scope).

(This one deserves its own issue, but I'm hesitant to spam your issue list. Let me know if you want a separate issue for it.) Finally, a function similar to pacdef package unmanaged that instead shows all explicitly installed packages along with which group(s) they're in; if unmanaged, show no group.

Hopefully that wasn't too much. It comes from a place of love. Your utility is incredibly useful and I'm excited to watch it continue to improve and grow.

@steven-omaha steven-omaha added the enhancement New feature or request label May 29, 2023
@steven-omaha
Copy link
Owner

Thanks for the suggestions!

Offer to save the group assignments on q quit. Currently all changes are lost until the entire list has been reviewed.

That sounds reasonable.

Allow multiple space delimited group assignments at the group assignment prompt.

So that you can save a single package in multiple groups? Do I have that right?

Allow going back to the previous package.

Yeah, that makes sense.

Allow creation of new groups while reviewing (understand if this is out of scope).

That's sensible as well.

(I had also thought about adding some of these, but did not do it because it was "good enough for me" at the time.) In total, that would be a complete overhaul of the review frontend. We could still do this prompt-based. I'm thinking whether it would be better to program a kind of menu.

Either way, I currently cannot commit to doing this due to other priorities, but I could definitely coach someone who would like to give it a try.

@ostrich you don't by chance have any experience with Rust and would like to try?

@steven-omaha steven-omaha added the help wanted Extra attention is needed label May 29, 2023
@ostrich
Copy link
Author

ostrich commented May 29, 2023

So that you can save a single package in multiple groups? Do I have that right?

Yup.

@ostrich you don't by chance have any experience with Rust and would like to try?

I wish. I'd love to help out if I could. I should use this as a kick in the pants to start looking into Rust.

@steven-omaha
Copy link
Owner

Understood. Then this will probably stay open for a while. Feel free to write something if the "kick in the pants" has successfully occurred. ;)

@steven-omaha
Copy link
Owner

@steven-omaha steven-omaha linked a pull request Jun 6, 2023 that will close this issue
1 task
steven-omaha added a commit that referenced this issue Mar 24, 2024
Add the 'a(p)ply' part to the review prompt, which applies all actions
that were put in so far. When the user has too many packages to review,
this allows them to process the packages in chunks of arbitrary sizes.

Related to #36.
@ripytide
Copy link
Contributor

Would making a TUI using ratatui be a good way of implementing this? I would be happy to take a shot at an implementation.

@steven-omaha
Copy link
Owner

ratatui is what I also thought of using here. If you'd like to give it a try, feel free!

Be advised though that #62 touches the same topic, but the fork from @mike-lloyd03 hasn't seen any commits for the past 3 weeks, so I'm not sure if he's abandoned this.

Thanks a lot!

@mike-lloyd03
Copy link
Contributor

I'm sorry. I gave NixOS another chance and seem to have things working. I'm still not sure if I'm committed to it but for now, I won't be able to work on #62. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants