This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Persistent tokens with TTL for SIP6 #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonf
changed the title
- Assert that FarmerInterface has storagePath - Only use ShardServer if storagePath supplied - Close shard token database for farmer when leaving
braydonf
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With SIP6 shard tokens can live longer from
ALLOCcommands. As such it'll be useful for the shard server to be able to persistent shard tokens across node restarts. Shard tokens will still have a TTL, however that TTL can now be much longer e.g. 24 hours. This will also be useful when implementing storj-archived/bridge#493Todo: