This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Bugfix/openprocess #121
Merged
Bugfix/openprocess #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littleskunk
reviewed
May 3, 2017
| @@ -83,8 +83,8 @@ class RPC { | |||
| start(configPath, callback, unsafeFlag=false) { | |||
| let config = null; | |||
|
|
|||
| if (this.shares.size + 1 >= cpus().length && !unsafeFlag) { | |||
| return callback(new Error('insufficient system resources available')); | |||
| if (this.shares.size >= cpus().length && !unsafeFlag) { | |||
There was a problem hiding this comment.
On a single core system this will still throw an error
1 farmer >= 1 core
it should be
1 farmer > 1 core
There was a problem hiding this comment.
I don't think so; this is in the start function so, by the end, it's modifying the state from 0 shares to +1 shares. Comparison is 0 farmers >= 1 core, unless I'm chasing my state management tail somewhere here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for single CPU cores. Can add a share now without warnings.