Skip to content
This repository was archived by the owner on Oct 30, 2018. It is now read-only.

Rotating log files #145

Merged
merged 6 commits into from
May 30, 2017
Merged

Rotating log files #145

merged 6 commits into from
May 30, 2017

Conversation

aleitner
Copy link
Contributor

@aleitner aleitner commented May 22, 2017 •
edited
Loading

@coveralls
Copy link

Coverage Status

Coverage decreased (-15.9%) to 84.103% when pulling e6b4178 on aleitner:master into 6af7a44 on Storj:master.

@aleitner aleitner changed the title Rotating log files [WIP] Rotating log files May 22, 2017
@aleitner aleitner changed the title [WIP] Rotating log files Rotating log files May 24, 2017
161chihuahuas
161chihuahuas suggested changes May 24, 2017
View reviewed changes
Copy link
Contributor

@161chihuahuas 161chihuahuas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but given that this changes the public api, will you go ahead and bump the major version tag in package.json?

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.05%) to 98.953% when pulling ac4f372 on aleitner:master into 6af7a44 on Storj:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 77809f5 on aleitner:master into 74e7a7a on Storj:master.

@161chihuahuas 161chihuahuas merged commit a822bb7 into storj-archived:master May 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@161chihuahuas 161chihuahuas 161chihuahuas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleitner @coveralls @161chihuahuas