objectinfo: simpler constructor #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erikvv
force-pushed
the
objectinfo-constructor
branch
17 times, most recently
from
d8c93f7 to
4a3d23f
Compare
Remove the C struct from the ObjectInfo constructor, so that ObjectInfo can be instantiated from user code. This allow the user to use this object in caching logic. Also change ownership of the go module cache in Jenkins to prevent permission errors.
Erikvv
force-pushed
the
objectinfo-constructor
branch
from
4a3d23f to
b7af854
Compare
halkyon
approved these changes
Dec 14, 2021
mniewrzal
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the C struct from the ObjectInfo constructor, so that ObjectInfo
can be instantiated from user code. This allow the user to use this
object in caching logic.
example usage: storj-thirdparty/nextcloud-app#15