Improve cross-platform compatibility of the build system #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkKirb
force-pushed
the
remove-linuxisms
branch
2 times, most recently
from
1975aa2 to
1a09356
Compare
GNU Make (which this project seemingly requires) reads GNUmakefile, then falls back to Makefile. Makefile is for POSIX Make. This also removes the now useless BSDmakefile, as Makefile no longer exists.
bash tends to not be available in /bin on non-GNU/Linux systems. Additionally the version of “bash” (zsh) macOS ships does not support the globstar option. Fixes storj#19 Closes storj#20 Altered from halkyon’s comment, as find requires a directory on non-GNU Co-Authored-By: Sean Harvey <halkyon@gmail.com>
Most of the scripts are just POSIX compatible shell scripts, sometimes with minor modifications in test-install, it tries to find GNU Make instead of using make (which is POSIX make) It also uses cc (the system compiler) instead of gcc which might not be available.
egonelbre
force-pushed
the
remove-linuxisms
branch
from
1a09356 to
ee5734f
Compare
egonelbre
approved these changes
May 10, 2023
amwolff
approved these changes
May 16, 2023
littleskunk
approved these changes
May 16, 2023
|
I merged as is, thank you for the contribution. |
eopb
added a commit
to eopb/uplink-rust
that referenced
this pull request
Jul 24, 2023
NixOS doesn't have `#!/bin/bash`. Bash can be on all Linuxes with `#!/usr/bin/env bash` so it's better to use that shebang. This doesn't actually enable building on NixOS since `uplink-c` also needs upgrading to a version that doesn't use `#!/bin/bash`: storj/uplink-c#24 storj-thirdparty#49
eopb
added a commit
to eopb/uplink-rust
that referenced
this pull request
Jul 25, 2023
NixOS doesn't have `#!/bin/bash`. Bash can be on all Linuxes with `#!/usr/bin/env bash` so it's better to use that shebang. This doesn't actually enable building on NixOS since `uplink-c` also needs upgrading to a version that doesn't use `#!/bin/bash`: storj/uplink-c#24 storj-thirdparty#49
eopb
added a commit
to eopb/uplink-rust
that referenced
this pull request
Jul 25, 2023
NixOS doesn't have `#!/bin/bash`. Bash can be found on all Linuxes with `#!/usr/bin/env bash` so it's better to use that shebang. This doesn't actually enable building on NixOS since `uplink-c` also needs upgrading to a version that doesn't use `#!/bin/bash`. This was done in storj/uplink-c#24 related storj-thirdparty#49
ifraixedes
pushed a commit
to storj-thirdparty/uplink-rust
that referenced
this pull request
Jul 25, 2023
NixOS doesn't have `#!/bin/bash`. Bash can be found on all Linuxes with `#!/usr/bin/env bash` so it's better to use that shebang. This doesn't actually enable building on NixOS since `uplink-c` also needs upgrading to a version that doesn't use `#!/bin/bash`. This was done in storj/uplink-c#24 related #49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently building uplink-c fails on NixOS, but seemingly also MacOS (#19) and *BSD (unreported).
This is because of two reasons:
I ported the scripts to POSIX shell, which should work on most recent UNIX-like operating systems.
Additionally, I addressed some potential portability concerns:
Fixes #19
Closes #20