Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default value for upper, lower options #87

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Change default value for upper, lower options #87

merged 2 commits into from
Feb 6, 2020

Conversation

Alhxor
Copy link
Contributor

@Alhxor Alhxor commented Feb 6, 2020

Description

Fixes #86 (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@strdr4605 strdr4605 self-requested a review February 6, 2020 10:06
strdr4605
strdr4605 requested changes Feb 6, 2020
View reviewed changes
Copy link
Owner

@strdr4605 strdr4605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change default value in @typedef for Options.

Also in README#Options.

@Alhxor
Copy link
Contributor Author

Alhxor commented Feb 6, 2020

Believe I've got them all now. My first PR ever:)

@Alhxor Alhxor requested a review from strdr4605 February 6, 2020 10:47
strdr4605
strdr4605 approved these changes Feb 6, 2020
View reviewed changes
Copy link
Owner

@strdr4605 strdr4605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for contribution and good luck with other open-source contributions!

@strdr4605 strdr4605 merged commit 36f2b1b into strdr4605:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strdr4605 strdr4605 strdr4605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default value for upper, lower options.
2 participants
@Alhxor @strdr4605