Add ConfigureAwait calls to async calls that are awaited #3002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
A user reported an issue with Stripe.net v46 where it would deadlock when executing a synchronous Get call on one of the services. After investigating, it looks like this call passes through several async calls that are missing ConfigureAsync(false) calls. ConfigureAsync(false) instructs the .NET task to not continue in the context captured when it is created; this is important because if that context is blocked (i.e. because we are synchronously waiting for a response), it will deadlock.
This problem was observed and subsequently reproduced on Windows using .NET Framework, and affects services created without using
StripeClient
(StripeClient
accessed services work as expected).What?
ConfigureAwait(false)
calls to all async/await methods that did not have themVerified this fix by running the following in a ASP.NET Framework app, inside the Home page request handler, and confirming that Get does return and the program does proceed: