stripe · ramya-stripe · Oct 10, 2024 · Oct 8, 2024 · Oct 9, 2024 · Oct 9, 2024
@@ -15,3 +15,6 @@ dotnet_style_qualification_for_field = true
 
 [CHANGELOG.md]
 trim_trailing_whitespace = false
+[src/Stripe.net/**/*.cs]
+
+dotnet_diagnostic.CA2007.severity = error
@@ -1,5 +1,9 @@
 # Changelog
 
+## 46.2.0 - 2024-10-09
+* [#3002](https://github.com/stripe/stripe-dotnet/pull/3002) Add ConfigureAwait calls to async calls that are awaited
+  * Fixes issue [#2998](https://github.com/stripe/stripe-dotnet/issues/2998) that was introduced in v46
+
 ## 46.2.0-beta.3 - 2024-10-08
 * [#2975](https://github.com/stripe/stripe-dotnet/pull/2975) Update generated code for beta
   * Add support for `SubmitCard` test helper method on resource `Issuing.Card`

@@ -4,7 +4,7 @@ update-version:
 	@perl -pi -e 's|<Version>[.\-\d\w]+</Version>|<Version>$(VERSION)</Version>|' src/Stripe.net/Stripe.net.csproj
 
 codegen-format:
-	dotnet format src/Stripe.net/Stripe.net.csproj --severity warn
+	TargetFramework=net5.0 dotnet format src/Stripe.net/Stripe.net.csproj --severity warn
 
 ci-test:
 	dotnet test --no-build src/StripeTests/StripeTests.csproj -c Release

@@ -151,7 +151,7 @@ public async Task<T> RequestAsync<T>(
             CancellationToken cancellationToken = default)
             where T : IStripeEntity
         {
-            return await this.Requestor.RequestAsync<T>(BaseAddress.Api, method, path, options, requestOptions, cancellationToken);
+            return await this.Requestor.RequestAsync<T>(BaseAddress.Api, method, path, options, requestOptions, cancellationToken).ConfigureAwait(false);
         }
 
         /// <inheritdoc/>
@@ -162,7 +162,7 @@ public async Task<Stream> RequestStreamingAsync(
             RequestOptions requestOptions,
             CancellationToken cancellationToken = default)
         {
-            return await this.Requestor.RequestStreamingAsync(BaseAddress.Api, method, path, options, requestOptions, cancellationToken);
+            return await this.Requestor.RequestStreamingAsync(BaseAddress.Api, method, path, options, requestOptions, cancellationToken).ConfigureAwait(false);
         }
 
         /// <summary>Sends a request to Stripe's API as a synchronous operation.</summary>
@@ -196,7 +196,7 @@ public async Task<StripeResponse> RawRequestAsync(
             RawRequestOptions requestOptions = null,
             CancellationToken cancellationToken = default)
         {
-            return await this.Requestor.RawRequestAsync(method, path, content, requestOptions, cancellationToken);
+            return await this.Requestor.RawRequestAsync(method, path, content, requestOptions, cancellationToken).ConfigureAwait(false);
         }
 
         /// <summary>

@@ -281,7 +281,7 @@ internal async IAsyncEnumerable<T> V2ListRequestAutoPagingAsync<T>(
                 url,
                 options,
                 requestOptions,
-                cancellationToken);
+                cancellationToken).ConfigureAwait(false);
 
             while (true)
             {
@@ -315,7 +315,7 @@ internal async IAsyncEnumerable<T> V2ListRequestAutoPagingAsync<T>(
                     page.NextPageUrl,
                     new BaseOptions(),
                     requestOptions,
-                    cancellationToken);
+                    cancellationToken).ConfigureAwait(false);
             }
         }
 
@@ -358,7 +358,7 @@ internal async IAsyncEnumerable<T> V1ListRequestAutoPagingAsync<T>(
                 url,
                 options,
                 requestOptions,
-                cancellationToken);
+                cancellationToken).ConfigureAwait(false);
 
             options = options ?? new ListOptions();
             bool iterateBackward = false;
@@ -417,7 +417,7 @@ internal async IAsyncEnumerable<T> V1ListRequestAutoPagingAsync<T>(
                     url,
                     options,
                     requestOptions,
-                    cancellationToken);
+                    cancellationToken).ConfigureAwait(false);
             }
         }
 
@@ -498,7 +498,7 @@ internal async IAsyncEnumerable<T> SearchRequestAutoPagingAsync<T>(
                 url,
                 options,
                 requestOptions,
-                cancellationToken);
+                cancellationToken).ConfigureAwait(false);
 
             options = options ?? new SearchOptions();
 
@@ -532,7 +532,7 @@ internal async IAsyncEnumerable<T> SearchRequestAutoPagingAsync<T>(
                     url,
                     options,
                     requestOptions,
-                    cancellationToken);
+                    cancellationToken).ConfigureAwait(false);
             }
         }
     }

diff --git a/src/Examples/NewExample.cs b/src/Examples/NewExample.cs
    using Stripe.V2.Billing;

    public class NewExample
    {

        public static async Task Run()
        {
            var apiKey = "{{API_KEY}}";

            try
            {
diff --git a/src/Examples/Program.cs b/src/Examples/Program.cs
        {
        }

        public static async Task Main(string[] args)
        {
            // To create an example, clone NewExample.cs, implement the example
            // copy this line and replace the class name with your new class.
diff --git a/src/Examples/V2/StripeWebhookHandler.cs b/src/Examples/V2/StripeWebhookHandler.cs
    private readonly StripeClient _client;
    private readonly string _webhookSecret;

    public WebhookController()
    {
        var apiKey = Environment.GetEnvironmentVariable("STRIPE_API_KEY");
        _client = new StripeClient(apiKey);

        _webhookSecret = Environment.GetEnvironmentVariable("WEBHOOK_SECRET");
    }

    [HttpPost]
	using Stripe.V2.Billing;

	public class NewExample
	{
Check warning on line 10 in src/Examples/NewExample.cs GitHub Actions / Build and test `An opening brace should not be followed by a blank line. (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1505.md)` Check warning on line 10 in src/Examples/NewExample.cs GitHub Actions / Build and test `An opening brace should not be followed by a blank line. (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1505.md)` Check warning on line 10 in src/Examples/NewExample.cs GitHub Actions / Build and test `An opening brace should not be followed by a blank line. (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1505.md)` Check warning on line 10 in src/Examples/NewExample.cs GitHub Actions / Build and test `An opening brace should not be followed by a blank line. (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1505.md)`

	public static async Task Run()
Check warning on line 12 in src/Examples/NewExample.cs GitHub Actions / Build and test `This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.` Check warning on line 12 in src/Examples/NewExample.cs GitHub Actions / Build and test `This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.` Check warning on line 12 in src/Examples/NewExample.cs GitHub Actions / Build and test `This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.` Check warning on line 12 in src/Examples/NewExample.cs GitHub Actions / Build and test `This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.`
	{
	var apiKey = "{{API_KEY}}";
Check warning on line 14 in src/Examples/NewExample.cs GitHub Actions / Build and test `The variable 'apiKey' is assigned but its value is never used` Check warning on line 14 in src/Examples/NewExample.cs GitHub Actions / Build and test `The variable 'apiKey' is assigned but its value is never used` Check warning on line 14 in src/Examples/NewExample.cs GitHub Actions / Build and test `The variable 'apiKey' is assigned but its value is never used` Check warning on line 14 in src/Examples/NewExample.cs GitHub Actions / Build and test `The variable 'apiKey' is assigned but its value is never used`

	try
	{
	{
	}

	public static async Task Main(string[] args)
Check warning on line 12 in src/Examples/Program.cs GitHub Actions / Build and test `This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.` Check warning on line 12 in src/Examples/Program.cs GitHub Actions / Build and test `This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.` Check warning on line 12 in src/Examples/Program.cs GitHub Actions / Build and test `This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.` Check warning on line 12 in src/Examples/Program.cs GitHub Actions / Build and test `This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.`
	{
	// To create an example, clone NewExample.cs, implement the example
	// copy this line and replace the class name with your new class.
	private readonly StripeClient _client;
	private readonly string _webhookSecret;

	public WebhookController()
Check warning on line 18 in src/Examples/V2/StripeWebhookHandler.cs GitHub Actions / Build and test `Non-nullable field '_webhookSecret' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.` Check warning on line 18 in src/Examples/V2/StripeWebhookHandler.cs GitHub Actions / Build and test `Non-nullable field '_webhookSecret' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.`
	{
	var apiKey = Environment.GetEnvironmentVariable("STRIPE_API_KEY");
	_client = new StripeClient(apiKey);

	_webhookSecret = Environment.GetEnvironmentVariable("WEBHOOK_SECRET");
Check warning on line 23 in src/Examples/V2/StripeWebhookHandler.cs GitHub Actions / Build and test `Possible null reference assignment.` Check warning on line 23 in src/Examples/V2/StripeWebhookHandler.cs GitHub Actions / Build and test `Possible null reference assignment.`
	}

	[HttpPost]