-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta SDK updates between Open API versions 1473 and 1505 #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changed Program to accept a command line argument with the name (relative to Examples namespace) of the example to run * updated existing examples * added usage instructions * added just recipe
* Update generated code for v1463 * Update generated code for v1494 * Update generated code for v1495 * Update generated code for v1501 * Update generated code for v1505 --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: prathmesh-stripe <165320323+prathmesh-stripe@users.noreply.github.com>
jar-stripe
approved these changes
Mar 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We are a bit behind on shipping updates to our beta SDKs. The last one was on Feb 7th for the Open API version 1472. The automated PR for updating the betas (#3053) now has breaking changes that is meant for the March GA release. Creating this PR manually to ship an update to the beta SDKs without including such breaking changes.
What?
Cherry picked each of the commits from #3053 until the one for Open API version 1505. This was the last version of the Open API before planned breaking changes started showing up
A thorough review of each change will give us
Additionally, the change to make political_exposure from string to enum is getting reverted since we added an override to do this revert to avoid a breaking change without a new major version
Codegen for openapi 1505.
Changelog
SucceedInputCollection
andTimeoutInputCollection
test helper methods on resourceTerminal.Reader
TargetDate
onOrderPaymentSettingsPaymentMethodOptionsAcssDebitOptions
,OrderPaymentSettingsPaymentMethodOptionsAcssDebit
,OrderPaymentSettingsPaymentMethodOptionsSepaDebitOptions
, andOrderPaymentSettingsPaymentMethodOptionsSepaDebit