Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include OPENAPI_VERSION into npm bundle #2257

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

arthurfiorette
Copy link
Contributor

@arthurfiorette arthurfiorette commented Jan 28, 2025

Why?

Currently, there's no way to trace back the openapi version to the generated client, since only VERSION is included, but not OPENAPI_VERSION.

When downloading the spec via https://raw.githubusercontent.com/stripe/openapi/refs/tags/<OPENAPI_VERSION>/openapi/spec3.json, OPENAPI_VERSION is required since versioning is not done using any other version value like 2024-12-18.acacia.

Having the file there would easily allow for a file read and access the right used version at runtime :)

What?

This PR simply as OPENAPI_VERSION into npm package contents.

@arthurfiorette arthurfiorette requested a review from a team as a code owner January 28, 2025 02:26
@arthurfiorette arthurfiorette requested review from helenye-stripe and removed request for a team January 28, 2025 02:26
Copy link

cla-assistant bot commented Jan 28, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jan 28, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@helenye-stripe helenye-stripe merged commit 04f409b into stripe:master Jan 29, 2025
9 checks passed
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
gurus00 pushed a commit to gurus00/stripe-node that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants