Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config feature update #25

Merged
merged 3 commits into from
Oct 12, 2021
Merged

config feature update #25

merged 3 commits into from
Oct 12, 2021

Conversation

jjung99
Copy link

@jjung99 jjung99 commented Oct 8, 2021

I added json file feature.

@suhhee1011
Copy link
Owner

Hi jiyun, thank you for add the JSON file feature to my repository.
I just reviewed your pull request and I found that there is some error that needs some work on it.

  1. It doesn't allow to accept the output option.
  2. It doesn't ignore other options which are not available.
  3. If the config file is missing any options, it does not have a default value specified.

I think it is good if these features are edited 👍

@jjung99
Copy link
Author

jjung99 commented Oct 11, 2021

Hi, I updated the cil.js file and added extra config test files.
Let me know if there is any confusion or issue!

@suhhee1011 suhhee1011 merged commit 29e51ae into suhhee1011:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants