-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sessionStorage support #49
base: master
Are you sure you want to change the base?
Conversation
Hi @Anon0x19 the only issue we faced is on the NextJs when the component is rendering on the server side! We are working on it, and we will be closing this Request with this week without any delay |
Thank you for the quick response @sushinpv! This fix should work on NextJs. I just tested it using nextjs-react-secure-storage-example. |
625b3e0
to
04b16d2
Compare
… with my own project
04b16d2
to
1671b62
Compare
Thanks a lot @Anon0x19 , Let me go through all the test cases and if everything looks good we will be able to release this new version within this week |
Awesome! Thank you again for getting back to me so quickly. You were right about the issue with certain Next.js versions. I tested it using By the way, for react, I had to change the usage from i.e Furthermore, it seems the issue arose from Thank you for your time and for looking into this and testing it further. |
This will be breaking change for the existing users, and integrations, I'll make the necessary changes and planning to close this in next two days |
I was anticipating the merge of pull/40. However, since it hasn't been merged yet, I thought the PR might have been discontinued. Given that others are also interested in this feature, I decided to implement it myself.
Previously, I created a PR but I noticed a few issues when integrating it into my own project. As a result, I decided to close that PR and have now raised this one with the necessary changes to ensure it works properly.
I hope we can get this feature merged soon, as it would be quite useful. If there are any further changes needed, please do let me know, as I am more than happy to assist with further contributions.