Scalacheck for aggregates and projections #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svalaskevicius
force-pushed
the
scalacheck
branch
from
1759c28 to
7645794
Compare
| case object Decrement extends UnitCommand { | ||
| def run(sut: Sut) = sut.synchronized { | ||
| val action = sut.runner.db(agg, Counter.counterAggregate.handleCommand(Counter.Decrement)) | ||
| sut.runner = sut.runner.run(action) match { |
There was a problem hiding this comment.
not particularly nice... I wonder if there is a better way?
|
|
||
| property("fails when below zero") = CounterSpec.property() | ||
|
|
||
| private object CounterSpec extends AggregateCommands[Counter.Event, Counter.flow.StateData, Int] { |
There was a problem hiding this comment.
@Fristi hi!
what do you think about this kind of test for an aggregate? I'll create a similar one for the door agg.
projections, however, will need something more clever than this...
is there an alternative approach you can think of?
There was a problem hiding this comment.
Sorry for the late response! Been busy lately with moving/new job 😄
There was a problem hiding this comment.
No problem!
Congrats on a new job :)
| @@ -0,0 +1,64 @@ | |||
| import java.awt.print.Book | |||
There was a problem hiding this comment.
Oops :) copy paste err.
|
I really like this direction! Especially the invariant property tests, great job! I have made some comments, see the diff |
svalaskevicius
pushed a commit
that referenced
this pull request
Feb 28, 2016
Scalacheck for aggregates and projections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to cover #13