Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add SEO docs #3946

Merged
merged 17 commits into from
Feb 16, 2022
Merged

[docs] add SEO docs #3946

merged 17 commits into from
Feb 16, 2022

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Feb 16, 2022

We talk about SEO on the homepage, so should clarify the benefits SvelteKit offers

I think this is enough that we could consider whether we still want to leave #1142 open. It's not exactly clear to me what else we could provide beyond this documentation in terms of site maps

@benmccann benmccann added the documentation Improvements or additions to documentation label Feb 16, 2022
@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2022

⚠️ No Changeset found

Latest commit: c789768

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@gavinr gavinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and I'm happy to close/resolve #1142 when it lands. Thank you.

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful page to have, but we can make it waaaay more concise. I agree with @Conduitry's feedback — this isn't a place to put grandiose marketing claims

Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
@Rich-Harris
Copy link
Member

I think we should probably leave #1142 open — we could probably do something to e.g. make prerendered pages available to a sitemap generator. It wouldn't be trivial, and it wouldn't cover all cases, but there's room for Kit to provide value

@Rich-Harris
Copy link
Member

This is appendixy content, it should probably go near the bottom (after typescript, perhaps?)

@Rich-Harris Rich-Harris merged commit 00e1132 into master Feb 16, 2022
@Rich-Harris Rich-Harris deleted the seo-docs branch February 16, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants