Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip log_if_contains_state if only logging literals #15468

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

Rich-Harris
Copy link
Member

To make console.log(some_state) more useful, we transform it to this, which prints a snapshot of the state along with instructions on how to do it yourself:

console.log(...$.log_if_contains_state('log', some_state));

There's no need to do this if you're just doing console.log('HERE') or console.log('WHY WONT THIS WORK') or whatever. There are doubtless other cases we could similarly optimise but literals are the obvious place to start

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 7, 2025

🦋 Changeset detected

Latest commit: 4ccc770

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15468

@Rich-Harris Rich-Harris merged commit eaf0087 into main Mar 7, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the optimise-literal-logging branch March 7, 2025 15:02
@github-actions github-actions bot mentioned this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants