Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace undefined with void 0 to avoid edge case #15511

Merged
merged 5 commits into from
Mar 14, 2025

Conversation

Ocean-OS
Copy link
Contributor

In closures, you can make a variable with the name undefined. Combined with the fact that Svelte converts some empty arguments to undefined, this could lead to weird edge cases. This PR fixes this, by replacing undefined with void 0 in all of these conversions.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: 05ed17b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15511

@Ocean-OS Ocean-OS changed the title fix: replace 'undefined' with 'void 0' to avoid edge case fix: replace undefined with void 0 to avoid edge case Mar 14, 2025
@Rich-Harris
Copy link
Member

good catch, thanks!

@Rich-Harris Rich-Harris merged commit 489f463 into sveltejs:main Mar 14, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Mar 14, 2025
@KyTiXo
Copy link

KyTiXo commented Mar 17, 2025

@Ocean-OS It took me a few minutes to understand the issue at-hand. It's honestly a beautiful edge-case that I've never thought about. 😂 Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants