fix: allow get_proxied_value to return original value when error #15577
+17
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15546
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).More details in the connected issue, but the TL;DNR version is that when running the dev server, the
init_array_prototype_warnings
function causes problems with the iframe/JavaScript interactions for 3rd party integrations, such as with Recurly and other payment providers. This is caused because the check for a proxied value involves passing thevalue
to check if it exists within.By simply wrapping the
get_proxied_value
function in atry/catch
, we avoid the problem of halting the JS run by the 3rd party script on the iframe it controls.Tests and linting
pnpm test
and lint the project withpnpm lint
I intended to write a test for this function, but it appears that the existing proxy test file only runs tests against the
proxy
function. I can still do that, but it seemed out of keeping with the patterns I see in the code base already.