Skip to content

Commit

Permalink
fix missing SONAME fields for libdrake.so and libdrake_marker.so
Browse files Browse the repository at this point in the history
Partially resolves: RobotLocomotion#15946
Relates: RobotLocomotion#15963
  • Loading branch information
svenevs committed Oct 28, 2021
1 parent 73214a9 commit c0d8aab
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
8 changes: 8 additions & 0 deletions common/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,14 @@ drake_cc_binary(
"drake_marker.cc",
"drake_marker.h",
],
linkopts = select({
"//tools/cc_toolchain:linux": [
"-pthread",
"-Wl,-soname,libdrake_marker.so",
],
# This is a bazel-default rule, and does not need @drake//
"@//conditions:default": [],
}),
linkshared = 1,
linkstatic = 1,
visibility = ["//visibility:private"],
Expand Down
8 changes: 8 additions & 0 deletions tools/install/libdrake/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ cc_whole_archive_library(
# contain any references to constituent shared libraries inside the build tree.
cc_binary(
name = "libdrake.so",
linkopts = select({
"//tools/cc_toolchain:linux": [
"-pthread",
"-Wl,-soname,libdrake.so",
],
# This is a bazel-default rule, and does not need @drake//
"@//conditions:default": [],
}),
linkshared = 1,
linkstatic = 1,
deps = [
Expand Down

0 comments on commit c0d8aab

Please sign in to comment.