New Apache Config Generator for HTTP Basic Authentication #5800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Restbed Generator
remove unused folder
Getting latest commits from original
- Added Json processing functions to model - Removed unnused code from restbed codegen class - Added response header processing to api template
Changed it to respect alphabetical order
Made the string joining java 7 compatible
Added samples
Update from master
updating master
added missing apache2 config gen in services file
|
To see that everything works correctly i temporarily chose isOAuth instead of isBasic, to see if the idea works. In the final version, this will be changed to isBasic in the template. |
stkrwork
changed the title
wing328
reviewed
Jun 9, 2017
|
|
||
| @Override | ||
| public CodegenType getTag() { | ||
| return CodegenType.OTHER; |
There was a problem hiding this comment.
What about introducing a new type "CONFIG" instead of using OTHER?
wing328
reviewed
Jun 9, 2017
| import io.swagger.codegen.DefaultCodegen; | ||
| import io.swagger.codegen.SupportingFile; | ||
|
|
||
| public class Apache2Confgen extends DefaultCodegen implements CodegenConfig { |
There was a problem hiding this comment.
What about naming the class as "Apache2ConfigCodegen" to make it consistent with other generators (clients, servers, documentations)?
|
@stkrwork thanks for the PR. I wonder if you can add the samples under "samples/config/petstore/apache2" so that we can get an idea of what the output looks like. |
added 2 commits
June 11, 2017 21:21
|
The samples are currently generated without the additional properties set. |
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
This is a work in progress implementation for an Apache Configuration Generation for protecting paths in an api. It only generates the location component of the apache configuration, not the whole configuration