Install the tini provided by debian in the dockerfile #1
+16
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile and CI build both
arm64andamd64versions. However thetinibinary that was installed was only foramd64This PR changes the tini version from pulling the binary from the github release page to installing the version distributed by Debian maintainers with
apt-get. There are some minor changes here: 1) I choose to not use the statically compiled binary because I trust the Debian maintainers to get the libc requirements all lined up, and 2) it installs the executable to/usr/bin/tini, https://github.com/krallin/tini?tab=readme-ov-file#debian I decided to just leave it there, but we could move it to/tiniif we care.Additionally buster debian is EoL so I bumped it to bookworm