Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: Fix class member naming checks #151

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

sbmueller
Copy link
Contributor

@sbmueller sbmueller commented Mar 27, 2025

Our guidelines are, that public and protected class members are snake_case without suffix. Only private members have a _ suffix.
Tested locally.

@sbmueller sbmueller requested a review from a team as a code owner March 27, 2025 08:34
@sbmueller sbmueller requested a review from Copilot March 27, 2025 08:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the clang-tidy configuration to enforce the new naming guidelines for class members.

  • Removes underscore suffixes for public and protected members
  • Explicitly adds configuration for public member suffix with an empty string

Copy link
Contributor

@reimerix reimerix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sbmueller sbmueller requested a review from armallen March 27, 2025 09:09
Copy link

@armallen armallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sbmueller sbmueller merged commit a8e60ed into main Mar 27, 2025
1 check passed
@sbmueller sbmueller deleted the smuller/clang-tidy-update branch March 27, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants