forked from eclipse-platform/eclipse.platform.swt
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows gdi skija #136
Draft
DenisUngemach
wants to merge
339
commits into
master
Choose a base branch
from
windows_gdi_skija
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Windows gdi skija #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Ungemach <denis.ungemach@sap.com>
The isScrolled-method is not longer needed and thus removed
one universal method that triggers a redraw only if the control's isEnabled state changes
because x and y from the bounds are irrelevant for drawing and encourage to use the rect incorrectly for filling
and delegates to .computeDefaultSize()
if the selection started at the beginning, pressing Left did not unselect it (same for end/Right)
First PoC: Execute the class window and check the feature. ------------------------------------------- Explanation In windows create a memory device context (dc) and point a skija surface to this dc. Basically it would always be possible to draw to the surface. In the paint method, use OS.BitBlt to push the memory area to the window. Ideas: -> It would also be possible to push only specific areas to the window. So redraw of specific areas is thinkable. -> Also multiple memory dcs could be used.
- The best alternative in windows GDI to vsync is the call of DwmFlush before BitBlt
Maven Build: Build-SWT-native-binaries-for-running-platform I had to add a new OS call: OS.DwmFlush() |
- now the PoC seems fine. It should be possible now to use it in SWT as base drawing feature. Of course for this all the eventing etc must be added.
a9f24e5
to
d2109d6
Compare
637b781
to
2365724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.