Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maven launchers #153

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Add maven launchers #153

merged 1 commit into from
Mar 13, 2025

Conversation

tmssngr
Copy link

@tmssngr tmssngr commented Mar 11, 2025

No description provided.

Copy link

github-actions bot commented Mar 11, 2025

Test Results

   341 files  ±0     341 suites  ±0   2m 48s ⏱️ +27s
 3 955 tests ±0   3 671 ✅ ±0  284 💤 ±0  0 ❌ ±0 
11 693 runs  ±0  10 808 ✅ ±0  885 💤 ±0  0 ❌ ±0 

Results for commit b82955a. ± Comparison against base commit 0377ff6.

♻️ This comment has been updated with latest results.

Copy link

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why we don't use the wrappers in the Eclipse projects. I used them for a long time in other projects but also read about some reasons for not adding them some years ago. Unfortunately, I don't find the information anymore and cannot remember either.

So I would be fine with adding them. If no one has any objections, feel free to merge.

@tmssngr
Copy link
Author

tmssngr commented Mar 12, 2025

I will wait a little bit for objections before merging.

BTW, when checking out this branch and invoking mvnw clean verify in a terminal on Windows, do all tests succeed for you?

@HeikoKlare
Copy link

BTW, when checking out this branch and invoking mvnw clean verify in a terminal on Windows, do all tests succeed for you?

No, there are some tests that even fail for me when locally executing the Maven build on SWT upstream state.

@tmssngr tmssngr force-pushed the feature/maven branch 2 times, most recently from 5ded40c to ee7c4d7 Compare March 12, 2025 17:51
@tmssngr tmssngr merged commit 1eea682 into master Mar 13, 2025
5 checks passed
@tmssngr tmssngr deleted the feature/maven branch March 13, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants