Proper SkijaGC disposal and initialization of device #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
skijagc-device-and-dispose
branch
from
5550027 to
bd3e3a1
Compare
SkijaGC does currently not initialize it's device, i.e., a call to SkijaGC#getDevice() always yields null. In addition, disposal handling of SkijaGC is broken as it always disposes the underlying native GC even if that is still supposed to be used and the the surface of the SkijaGC is already disposed at commit instead of upon disposal. These issues are addressed by this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkijaGC does currently not initialize it's device, i.e., a call to SkijaGC#getDevice() always yields null. In addition, disposal handling of SkijaGC is broken as it always disposes the underlying native GC even if that is still supposed to be used and the the surface of the SkijaGC is already disposed at commit instead of upon disposal. These issues are addressed by this change.