Fix text extent calculation in SkijaGC #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
skijagc-extent-calculation
branch
2 times, most recently
from
61e6dc8 to
fb0a667
Compare
HeikoKlare
force-pushed
the
skijagc-extent-calculation
branch
2 times, most recently
from
15b9ae1 to
9327caf
Compare
SkijaGC text extent calculation did not properly consider trailing whitespaces. The bounding box calculated by the textExtent operation does not consider those whitespaces. This change replaces the calculation to properly consider the actual text width and the height of the font instead of the height of the actual text to conform with the behavior of existing GC implementations.
HeikoKlare
force-pushed
the
skijagc-extent-calculation
branch
from
9327caf to
84eb042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SkijaGC text extent calculation did not properly consider trailing whitespaces. The bounding box calculated by the textExtent operation does not consider those whitespaces. This change replaces the calculation to properly consider the actual text width and the height of the font instead of the height of the actual text to conform with the behavior of existing GC implementations.