Make Text widget use SkijaGC if enabled #159
Merged
+50
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
text-use-skija
branch
from
897d082 to
aca08a1
Compare
tmssngr
reviewed
Mar 13, 2025
bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics/SkijaGC.java
Show resolved
Hide resolved
The transparency flag and argument of SkijaGCs drawText methods have not been considered. With this change, the background of the text is drawn if the transparent flag is not set as defined by the API.
Currently, the Text widget based on CSimpleText uses the original (native) GC. With this change, it performs rendering based on a SkijaGC if enabled.
HeikoKlare
force-pushed
the
text-use-skija
branch
from
aca08a1 to
8e5b700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Text widget based on CSimpleText uses the original (native) GC. With this change, it performs rendering based on a SkijaGC if enabled.
To this end, the PR also adds proper handling for the transparency flag when drawing text with SkijaGC. The transparency flag and argument of SkijaGCs drawText methods have not been considered. With this change, the background of the text is drawn if the transparent flag is not set as defined by the API.