Fix multi-line anchor tag issue. #163
Open
+123
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anchor tag within a link text can have new line character(\n). Link should be underlined in multiple lines. Other improvements. See #154
raghucssit
force-pushed
the
link_widget_parse_fix
branch
from
62ca799 to
54aef38
Compare
|
I would suggest to make the parsing code testable independent of the Link control, e.g. by making it static. I also recommend adding test cases for the parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anchor tag within a link text can have new line character(\n). Link should be underlined in multiple lines.
Other improvements.
See #154